From 74c733308f10462f6672235ef2ee71676cb2deb9 Mon Sep 17 00:00:00 2001
From: Ean Milligan <ean.milligan@gmail.com>
Date: Sat, 26 Apr 2025 22:44:39 -0400
Subject: [PATCH] linting/type cleanup

---
 src/commands/audit.ts            |  2 +-
 src/commands/auditCmd/auditDB.ts | 10 ++++++++--
 src/commands/heatmap.ts          |  2 +-
 src/commands/optIn.ts            |  2 +-
 src/commands/optOut.ts           |  2 +-
 src/commands/ping.ts             |  2 +-
 src/commands/stats.ts            |  2 +-
 src/intervals.ts                 |  6 ++++--
 8 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/src/commands/audit.ts b/src/commands/audit.ts
index af27a7b..7f2d4b5 100644
--- a/src/commands/audit.ts
+++ b/src/commands/audit.ts
@@ -9,7 +9,7 @@ import auditCommands from './auditCmd/_index.ts';
 import { failColor } from '../commandUtils.ts';
 import utils from '../utils.ts';
 
-export const audit = async (message: DiscordenoMessage, args: string[]) => {
+export const audit = (message: DiscordenoMessage, args: string[]) => {
   // Light telemetry to see how many times a command is being run
   dbClient.execute(queries.callIncCnt('audit')).catch((e) => utils.commonLoggers.dbError('audit.ts:16', 'call sproc INC_CNT on', e));
 
diff --git a/src/commands/auditCmd/auditDB.ts b/src/commands/auditCmd/auditDB.ts
index d58c1b5..571741d 100644
--- a/src/commands/auditCmd/auditDB.ts
+++ b/src/commands/auditCmd/auditDB.ts
@@ -8,6 +8,12 @@ import { infoColor2 } from '../../commandUtils.ts';
 import { compilingStats } from '../../commonEmbeds.ts';
 import utils from '../../utils.ts';
 
+interface DBSizeData {
+  table: string;
+  size: string;
+  rows: number;
+}
+
 export const auditDB = async (message: DiscordenoMessage) => {
   try {
     const m = await message.send(compilingStats);
@@ -17,7 +23,7 @@ export const auditDB = async (message: DiscordenoMessage) => {
 
     // Turn all tables into embed fields, currently only properly will handle 25 tables, but we'll fix that when artificer gets 26 tables
     const embedFields: Array<EmbedField> = [];
-    auditQuery.forEach((row: any) => {
+    auditQuery.forEach((row: DBSizeData) => {
       embedFields.push({
         name: `${row.table}`,
         value: `**Size:** ${row.size} MB
@@ -39,6 +45,6 @@ export const auditDB = async (message: DiscordenoMessage) => {
       ],
     }).catch((e: Error) => utils.commonLoggers.messageEditError('auditDB.ts:43', message, e));
   } catch (e) {
-    utils.commonLoggers.messageSendError('auditDB.ts:45', message, e);
+    utils.commonLoggers.messageSendError('auditDB.ts:45', message, e as Error);
   }
 };
diff --git a/src/commands/heatmap.ts b/src/commands/heatmap.ts
index 26393b7..edd448c 100644
--- a/src/commands/heatmap.ts
+++ b/src/commands/heatmap.ts
@@ -9,7 +9,7 @@ import { failColor, infoColor2 } from '../commandUtils.ts';
 import utils from '../utils.ts';
 import intervals from '../intervals.ts';
 
-export const heatmap = async (message: DiscordenoMessage) => {
+export const heatmap = (message: DiscordenoMessage) => {
   // Light telemetry to see how many times a command is being run
   dbClient.execute(queries.callIncCnt('heatmap')).catch((e) => utils.commonLoggers.dbError('heatmap.ts:14', 'call sproc INC_CNT on', e));
 
diff --git a/src/commands/optIn.ts b/src/commands/optIn.ts
index e105102..5a897e4 100644
--- a/src/commands/optIn.ts
+++ b/src/commands/optIn.ts
@@ -31,7 +31,7 @@ export const optIn = async (message: DiscordenoMessage) => {
           ],
         })
         .catch((e: Error) => utils.commonLoggers.messageSendError('optIn.ts:27', message, e));
-    } catch (err) {
+    } catch (_e) {
       message
         .reply({
           embeds: [
diff --git a/src/commands/optOut.ts b/src/commands/optOut.ts
index 4b2b9b9..6701502 100644
--- a/src/commands/optOut.ts
+++ b/src/commands/optOut.ts
@@ -29,7 +29,7 @@ export const optOut = async (message: DiscordenoMessage) => {
         ],
       })
       .catch((e: Error) => utils.commonLoggers.messageSendError('optOut.ts:25', message, e));
-  } catch (err) {
+  } catch (_e) {
     message
       .reply({
         embeds: [
diff --git a/src/commands/ping.ts b/src/commands/ping.ts
index 67d1890..13a9179 100644
--- a/src/commands/ping.ts
+++ b/src/commands/ping.ts
@@ -16,6 +16,6 @@ export const ping = async (message: DiscordenoMessage) => {
     const m = await message.send(generatePing(-1));
     m.edit(generatePing(m.timestamp - message.timestamp));
   } catch (e) {
-    utils.commonLoggers.messageSendError('ping.ts:23', message, e);
+    utils.commonLoggers.messageSendError('ping.ts:23', message, e as Error);
   }
 };
diff --git a/src/commands/stats.ts b/src/commands/stats.ts
index 188d421..b2bb04a 100644
--- a/src/commands/stats.ts
+++ b/src/commands/stats.ts
@@ -44,6 +44,6 @@ export const stats = async (message: DiscordenoMessage) => {
       ),
     ).catch((e: Error) => utils.commonLoggers.messageEditError('stats.ts:38', m, e));
   } catch (e) {
-    utils.commonLoggers.messageSendError('stats.ts:41', message, e);
+    utils.commonLoggers.messageSendError('stats.ts:41', message, e as Error);
   }
 };
diff --git a/src/intervals.ts b/src/intervals.ts
index 89363c4..2788f5d 100644
--- a/src/intervals.ts
+++ b/src/intervals.ts
@@ -62,7 +62,8 @@ const updateListStatistics = (botID: bigint, serverCount: number): void => {
         });
         log(LT.INFO, `Posted server count to ${e.name}.  Results: ${JSON.stringify(response)}`);
       }
-    } catch (err) {
+    } catch (error) {
+      const err = error as Error;
       log(LT.ERROR, `Failed to update statistics for ${e.name} | Error: ${err.name} - ${err.message}`);
     }
   });
@@ -103,7 +104,8 @@ const updateHourlyRates = async () => {
     if (previousHours.length > hoursToKeep) {
       previousHours.unshift();
     }
-  } catch (e) {
+  } catch (err) {
+    const e = err as Error;
     log(LT.ERROR, `Something went wrong in previousHours interval | Error: ${e.name} - ${e.message}`);
   }
 };