From dba1976a8e2640700c425b7efe64507027840bab Mon Sep 17 00:00:00 2001
From: "Ean Milligan (Bastion)" <ean.milligan@gmail.com>
Date: Wed, 22 Jun 2022 01:57:38 -0400
Subject: [PATCH] Add messages to all api calls

---
 src/api.ts                                   | 2 +-
 src/endpoints/deletes/apiKeyDelete.ts        | 4 ++--
 src/endpoints/gets/apiChannel.ts             | 4 ++--
 src/endpoints/gets/apiKey.ts                 | 4 ++--
 src/endpoints/gets/apiKeyAdmin.ts            | 4 ++--
 src/endpoints/gets/apiRoll.ts                | 2 +-
 src/endpoints/posts/apiChannelAdd.ts         | 4 ++--
 src/endpoints/puts/apiChannelManageActive.ts | 4 ++--
 src/endpoints/puts/apiChannelManageBan.ts    | 4 ++--
 src/endpoints/puts/apiKeyManage.ts           | 4 ++--
 src/endpoints/stdResponses.ts                | 4 ++++
 11 files changed, 22 insertions(+), 18 deletions(-)

diff --git a/src/api.ts b/src/api.ts
index b18cde4..a187a81 100644
--- a/src/api.ts
+++ b/src/api.ts
@@ -205,7 +205,7 @@ const start = async (): Promise<void> => {
 					requestEvent.respondWith(stdResp.TooManyRequests('Slow down, servers are expensive and this bot is free to use.'));
 				} else {
 					// Alert API user that they shouldn't be doing this
-					requestEvent.respondWith(stdResp.Forbidden(''));
+					requestEvent.respondWith(stdResp.Forbidden('Why are you here?'));
 				}
 			}
 		})();
diff --git a/src/endpoints/deletes/apiKeyDelete.ts b/src/endpoints/deletes/apiKeyDelete.ts
index 23f6db0..b14e811 100644
--- a/src/endpoints/deletes/apiKeyDelete.ts
+++ b/src/endpoints/deletes/apiKeyDelete.ts
@@ -76,10 +76,10 @@ export const apiKeyDelete = async (requestEvent: Deno.RequestEvent, query: Map<s
 			}
 		} else {
 			// Alert API user that they shouldn't be doing this
-			requestEvent.respondWith(stdResp.Forbidden(''));
+			requestEvent.respondWith(stdResp.Forbidden('You can only delete your own key.'));
 		}
 	} else {
 		// Alert API user that they messed up
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/gets/apiChannel.ts b/src/endpoints/gets/apiChannel.ts
index dee9316..e3c6b6c 100644
--- a/src/endpoints/gets/apiChannel.ts
+++ b/src/endpoints/gets/apiChannel.ts
@@ -30,10 +30,10 @@ export const apiChannel = async (requestEvent: Deno.RequestEvent, query: Map<str
 			}
 		} else {
 			// Alert API user that they shouldn't be doing this
-			requestEvent.respondWith(stdResp.Forbidden(''));
+			requestEvent.respondWith(stdResp.Forbidden('You can only view your own channels.'));
 		}
 	} else {
 		// Alert API user that they messed up
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/gets/apiKey.ts b/src/endpoints/gets/apiKey.ts
index 9425714..549b832 100644
--- a/src/endpoints/gets/apiKey.ts
+++ b/src/endpoints/gets/apiKey.ts
@@ -44,11 +44,11 @@ export const apiKey = async (requestEvent: Deno.RequestEvent, query: Map<string,
 			return;
 		} else {
 			// Send basic OK to indicate key has been sent
-			requestEvent.respondWith(stdResp.OK(''));
+			requestEvent.respondWith(stdResp.OK('Email Sent.'));
 			return;
 		}
 	} else {
 		// Alert API user that they messed up
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/gets/apiKeyAdmin.ts b/src/endpoints/gets/apiKeyAdmin.ts
index 169a3f5..f77f86f 100644
--- a/src/endpoints/gets/apiKeyAdmin.ts
+++ b/src/endpoints/gets/apiKeyAdmin.ts
@@ -35,10 +35,10 @@ export const apiKeyAdmin = async (requestEvent: Deno.RequestEvent, query: Map<st
 			}
 		} else {
 			// Only allow the db admin to use this API
-			requestEvent.respondWith(stdResp.Forbidden(''));
+			requestEvent.respondWith(stdResp.Forbidden(stdResp.Strings.restricted));
 		}
 	} else {
 		// Alert API user that they messed up
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/gets/apiRoll.ts b/src/endpoints/gets/apiRoll.ts
index b5aedb7..10c54a8 100644
--- a/src/endpoints/gets/apiRoll.ts
+++ b/src/endpoints/gets/apiRoll.ts
@@ -119,6 +119,6 @@ export const apiRoll = async (requestEvent: Deno.RequestEvent, query: Map<string
 		}
 	} else {
 		// Alert API user that they shouldn't be doing this
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/posts/apiChannelAdd.ts b/src/endpoints/posts/apiChannelAdd.ts
index 3851818..60ae2be 100644
--- a/src/endpoints/posts/apiChannelAdd.ts
+++ b/src/endpoints/posts/apiChannelAdd.ts
@@ -29,10 +29,10 @@ export const apiChannelAdd = async (requestEvent: Deno.RequestEvent, query: Map<
 			}
 		} else {
 			// Alert API user that they shouldn't be doing this
-			requestEvent.respondWith(stdResp.Forbidden(''));
+			requestEvent.respondWith(stdResp.Forbidden('You can only add channels to your key.'));
 		}
 	} else {
 		// Alert API user that they messed up
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/puts/apiChannelManageActive.ts b/src/endpoints/puts/apiChannelManageActive.ts
index c48e63b..31a0c2a 100644
--- a/src/endpoints/puts/apiChannelManageActive.ts
+++ b/src/endpoints/puts/apiChannelManageActive.ts
@@ -36,10 +36,10 @@ export const apiChannelManageActive = async (requestEvent: Deno.RequestEvent, qu
 			}
 		} else {
 			// Alert API user that they shouldn't be doing this
-			requestEvent.respondWith(stdResp.Forbidden(''));
+			requestEvent.respondWith(stdResp.Forbidden('You can only manage your own channels.'));
 		}
 	} else {
 		// Alert API user that they messed up
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/puts/apiChannelManageBan.ts b/src/endpoints/puts/apiChannelManageBan.ts
index 4815d42..066f6a8 100644
--- a/src/endpoints/puts/apiChannelManageBan.ts
+++ b/src/endpoints/puts/apiChannelManageBan.ts
@@ -40,10 +40,10 @@ export const apiChannelManageBan = async (requestEvent: Deno.RequestEvent, query
 			}
 		} else {
 			// Alert API user that they shouldn't be doing this
-			requestEvent.respondWith(stdResp.Forbidden(''));
+			requestEvent.respondWith(stdResp.Forbidden(stdResp.Strings.restricted));
 		}
 	} else {
 		// Alert API user that they messed up
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/puts/apiKeyManage.ts b/src/endpoints/puts/apiKeyManage.ts
index 2970089..f66930b 100644
--- a/src/endpoints/puts/apiKeyManage.ts
+++ b/src/endpoints/puts/apiKeyManage.ts
@@ -46,10 +46,10 @@ export const apiKeyManage = async (requestEvent: Deno.RequestEvent, query: Map<s
 			}
 		} else {
 			// Alert API user that they shouldn't be doing this
-			requestEvent.respondWith(stdResp.Forbidden(''));
+			requestEvent.respondWith(stdResp.Forbidden('You can only manage your own key.'));
 		}
 	} else {
 		// Alert API user that they messed up
-		requestEvent.respondWith(stdResp.BadRequest(''));
+		requestEvent.respondWith(stdResp.BadRequest(stdResp.Strings.missingParams));
 	}
 };
diff --git a/src/endpoints/stdResponses.ts b/src/endpoints/stdResponses.ts
index 2f94d47..7df7614 100644
--- a/src/endpoints/stdResponses.ts
+++ b/src/endpoints/stdResponses.ts
@@ -16,4 +16,8 @@ export default {
 	OK: (customText: string) => genericResponse(customText, Status.OK),
 	RequestTimeout: (customText: string) => genericResponse(customText, Status.RequestTimeout),
 	TooManyRequests: (customText: string) => genericResponse(customText, Status.TooManyRequests),
+	Strings: {
+		missingParams: 'Missing Parameters.',
+		restricted: 'This API is restricted.',
+	},
 };